Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invisible result warning opt-in #373

Merged
merged 7 commits into from
Jul 14, 2020
Merged

Make invisible result warning opt-in #373

merged 7 commits into from
Jul 14, 2020

Conversation

nischalshrestha
Copy link
Contributor

@nischalshrestha nischalshrestha commented May 22, 2020

Fixes #369

Allow the invisible result warning to be configured/disabled as an exercise chunk option called "warn_invisible". The default behavior is no warning.

Example file
---
title: "Warn invisible"
output: learnr::tutorial
runtime: shiny_prerendered
---

The following code chunks demonstrates normal exercise without a `warn_invisible` option set.

```{r no-invisible-warning, exercise=TRUE}
x <- 1
```

This chunk sets a `warn_invisible` option to `FALSE`.

```{r with-invisible-warning-1, exercise=TRUE, exercise.warn_invisible = FALSE}
x <- 1
```

This chunk sets a `warn_invisible` option to `TRUE`.
```{r with-invisible-warning-2, exercise=TRUE, exercise.warn_invisible = TRUE}
x <- 1
```

@CLAassistant
Copy link

CLAassistant commented May 22, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nischalshrestha
❌ Nischal Shrestha


Nischal Shrestha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ericemc3
Copy link

I am interested by this feature

@Brunox13
Copy link

Looks like this valuable PR is hung up on a likely erroneous CLA signature requirement for a non-existing alias of the same user?

@cpsievert cpsievert self-requested a review July 13, 2020 18:34
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comment (and merge conflicts)

@nischalshrestha nischalshrestha changed the title Fixes issue #369: invisible result warning. Make invisible result warning opt-in Jul 14, 2020
@schloerke schloerke merged commit 859c946 into master Jul 14, 2020
@schloerke schloerke deleted the fix_warn_invisible branch July 14, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when exercise gives invisible result
6 participants