Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos, clarification, wrong hint reference... #391

Merged
merged 1 commit into from Jul 14, 2020

Conversation

stragu
Copy link
Contributor

@stragu stragu commented Jun 29, 2020

I had a look at the PR requirements, but thought I might pass on them as these are minor fixes that don't necessarily need a NEWS entry, and definitely not a test. Hope that's OK.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2020

CLA assistant check
All committers have signed the CLA.

@schloerke
Copy link
Collaborator

@stragu The changes look great! Do you mind filling out the CLA form? It will allow me to merge the PR.

Thank you!

@stragu
Copy link
Contributor Author

stragu commented Jul 3, 2020

@schloerke : Done!

@schloerke
Copy link
Collaborator

@stragu Sorry to still bother you.

Do you mind double checking you filled out the CLA form with the correct email / username? We should be able to see the CLA check turn from yellow to green once it works.

Thank you again!

@stragu
Copy link
Contributor Author

stragu commented Jul 7, 2020

Thanks, @schloerke ! Very odd, I was sure I had gone through the process 🤔

@schloerke schloerke merged commit 659b1bb into rstudio:master Jul 14, 2020
@stragu stragu deleted the patch-1 branch July 14, 2020 22:15
sjgknight pushed a commit to sjgknight/learnr that referenced this pull request Aug 10, 2021
Co-authored-by: Stéphane Guillou <stephane.guillou@member.fsf.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants