Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colin/output styles #438

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Colin/output styles #438

wants to merge 31 commits into from

Commits on Sep 23, 2020

  1. update of the CSS to include the alerts

    @ColinFay
    ColinFay committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5777ccd View commit details
    Browse the repository at this point in the history

  2. refactoring of the tutorial_options function to make it easier to add… 

    … new options, plus added some new options for the new alert mechanism
    @ColinFay
    ColinFay committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7c26c17 View commit details
    Browse the repository at this point in the history

  3. new alerts for learnr itself and for gradethis outputs

    @ColinFay
    ColinFay committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    0386c1a View commit details
    Browse the repository at this point in the history

  4. An example Rmd with colored outputs

    @ColinFay
    ColinFay committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    99d44ea View commit details
    Browse the repository at this point in the history

  5. Sandbox Rmd for gradethis colored outputs

    @ColinFay
    ColinFay committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    6ad4d4b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. refactor to a switch statement

    @ColinFay
    ColinFay committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    cc3abee View commit details
    Browse the repository at this point in the history

  2. explicitely specifying argument name (was provoking a bug before)

    @ColinFay
    ColinFay committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    43ea722 View commit details
    Browse the repository at this point in the history

  3. Allow to set options for showing learnr and gradethis feedbacks or not

    @ColinFay
    ColinFay committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    789920a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Back to is.missing

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    4d6b53f View commit details
    Browse the repository at this point in the history

  2. remove unused arg

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    2f3a3de View commit details
    Browse the repository at this point in the history

  3. use default colors when not specified

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    ddbd09a View commit details
    Browse the repository at this point in the history

  4. Documentation of options

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f9933df View commit details
    Browse the repository at this point in the history

  5. used correct colors for Rmd

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0c2b9e0 View commit details
    Browse the repository at this point in the history

  6. set default values here

    @ColinFay
    ColinFay committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    8d31eda View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Update R/options.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    79e2d41 View commit details
    Browse the repository at this point in the history

  2. Renamed to submitted_feedback & submitted_output

    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    31f3e51 View commit details
    Browse the repository at this point in the history

  3. the class is now fully provided, and is not pasted with alert-

    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b96eed0 View commit details
    Browse the repository at this point in the history

  4. exercise.feedback_show, exercise.code_show, exercise.gradethis_feedba… 

    …ck_show and exercise.gradethis_code_show are now set to TRUE if exercise$check and exercise$code_check are NULL
    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    eba0811 View commit details
    Browse the repository at this point in the history

  5. fully switched to class name

    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    aeedfc7 View commit details
    Browse the repository at this point in the history

  6. Forgot a space in paste0

    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    6e3747c View commit details
    Browse the repository at this point in the history

  7. correct option names

    @ColinFay
    ColinFay committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e19cae9 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Output is always printed when pressing Run Code, and colored box is a… 

    …dded when error is returned
    @ColinFay
    ColinFay committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    8fb0831 View commit details
    Browse the repository at this point in the history

  2. typo

    @ColinFay
    ColinFay committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    bfde555 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. padding table on outputs

    @ColinFay
    ColinFay committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    dc4cde2 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1cbace0 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. unsetting the color background when it's a learnr feedback

    @ColinFay
    ColinFay committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    677664e View commit details
    Browse the repository at this point in the history

  2. Update R/exercise.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    ab0f6c2 View commit details
    Browse the repository at this point in the history

  3. return(exercise_result(html_output = " ", exercise = NULL))

    @ColinFay
    ColinFay committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    63aaf69 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Update R/exercise.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    8d58d02 View commit details
    Browse the repository at this point in the history

  2. Update R/exercise.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a606776 View commit details
    Browse the repository at this point in the history

  3. Update R/exercise.R 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @ColinFay @schloerke
    ColinFay and schloerke committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    f50731a View commit details
    Browse the repository at this point in the history