Add Error handler from within plumb
#507
Conversation
R/plumber.R
Outdated
| @@ -811,6 +811,10 @@ plumber <- R6Class( | |||
| globalSettings = list(info=list()), # Global settings for this API. Primarily used for Swagger docs. | |||
|
|
|||
| errorHandler = NULL, | |||
| setErrorHandlerInternal = function(errorhandler){ | |||
There was a problem hiding this comment.
I would delete this method as there is already a public setErrorHandler method. (This can be reached using self$setErrorHandler in the evaluateBlock call above.)
There was a problem hiding this comment.
Thanks, for this pointer that's exactly what I was missing when trying to access setErrorHandler earlier.
R/plumber.R
Outdated
| @@ -220,7 +220,7 @@ plumber <- R6Class( | |||
| srcref <- attr(e, "srcref")[[1]][c(1,3)] | |||
|
|
|||
| evaluateBlock(srcref, private$lines, e, private$envir, private$addEndpointInternal, | |||
| private$addFilterInternal, self$mount) | |||
| private$addFilterInternal, private$setErrorHandlerInternal, self$mount) | |||
There was a problem hiding this comment.
Use self$setErrorHandler
jonkeane
force-pushed
the
errorHandler
branch
from
c346161
to
8478f14
Compare
|
Ok, I've addressed the comments and clarified the error message. Sorry for the rebase I realized I had the wrong email address associated previously. |
|
|
|
This PR is good. However, I am hoping to go in a different direction completely. With an I'm going to add it to the next release milestone for tracking, but it should be handled by a different PR. |
|
Done in #568 , can be closed I think. |
|
#568 did solve this. Thinking more in it... doesn't mean this can't also exist. Notes for later... Since this function is a one off function, like a filter, it should be treated like a filter. (Should not be able to add routes and an error handler at the same time.) The |
| @@ -236,7 +250,7 @@ parseBlock <- function(lineNum, file){ | |||
| #' Evaluate and activate a "block" of code found in a plumber API file. | |||
| #' @include images.R | |||
| #' @noRd | |||
| evaluateBlock <- function(srcref, file, expr, envir, addEndpoint, addFilter, mount) { | |||
| evaluateBlock <- function(srcref, file, expr, envir, addEndpoint, addFilter, setErrorHandler, mount) { | |||
There was a problem hiding this comment.
no need anymore since #568.
| @@ -273,6 +287,9 @@ evaluateBlock <- function(srcref, file, expr, envir, addEndpoint, addFilter, mou | |||
| filter <- PlumberFilter$new(block$filter, expr, envir, block$serializer, srcref) | |||
| addFilter(filter) | |||
|
|
|||
| } else if (!is.null(block$errorhandler)){ | |||
| setErrorHandler(eval(expr)) | |||
There was a problem hiding this comment.
Since the plumberRouter is now passed to evaluateBlock, use pr$setErrorHandler directly
| @@ -220,7 +220,7 @@ plumber <- R6Class( | |||
| srcref <- attr(e, "srcref")[[1]][c(1,3)] | |||
|
|
|||
| evaluateBlock(srcref, private$lines, e, private$envir, private$addEndpointInternal, | |||
| private$addFilterInternal, self$mount) | |||
| private$addFilterInternal, self$setErrorHandler, self$mount) | |||
|
Thanks for the PR @jonkeane. Since we can already set a custom error handler via handler <- function(req, res, err) {
rlang::abort(err)
}
#* @plumber
function(pr) {
pr %>% pr_set_error(handler)
} |
From #506 via @jonkeane