Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add router modifier tag support (#' @plumber) #568

Merged
merged 8 commits into from Jun 26, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 24, 2020

Add support for a @plumber tag that use the expr to modify the plumber router programmatically.

#* @plumber
function(pr){
  pr$handle("GET", "/avatartare", function(raw) {raw}, serializer = serializer_json)
}

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke
Copy link
Collaborator

schloerke commented Jun 25, 2020

I'm so excited for this PR. Thank you @meztez !

cc @blairj09

NEWS.md Outdated Show resolved Hide resolved
R/plumb-block.R Outdated Show resolved Hide resolved
R/plumb-block.R Outdated Show resolved Hide resolved
R/plumb-block.R Outdated Show resolved Hide resolved
meztez and others added 4 commits Jun 25, 2020
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke schloerke requested review from schloerke and cpsievert Jun 25, 2020
NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
R/plumb-block.R Outdated Show resolved Hide resolved
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@cpsievert cpsievert self-requested a review Jun 25, 2020
Copy link
Contributor

@cpsievert cpsievert left a comment

🎉

@schloerke schloerke changed the title add router modifier tag support (#* @plumber) Add router modifier tag support (#' @plumber) Jun 26, 2020
@schloerke schloerke merged commit 43067ff into rstudio:master Jun 26, 2020
15 checks passed
schloerke added a commit that referenced this pull request Jun 26, 2020
* master:
  Add router modifier tag support (`#' @plumber`) (#568)
  Clean up print method (#565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants