Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misnamed properties private$filename #638

Merged
merged 1 commit into from Aug 7, 2020
Merged

Misnamed properties private$filename #638

merged 1 commit into from Aug 7, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Aug 7, 2020

Go this error while deploying with plumber devtools using entrypoint.

> plumb(dir='api')$run()
Running plumber API at http://0.0.0.0:8004

 Error in dirname(private$file) : a character vector argument expected
7.dirname(private$file)
6.setwd(dirname(private$file))
5.pr$run(host = "0.0.0.0", port = 8004) at entrypoint.R#8
4.eval(exprs, envir)
3.eval(exprs, envir)
2.sourceUTF8(entrypoint, new.env(parent = globalenv()))
1.plumb(dir = "api")
>

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@meztez
Misnamed properties private$filename
c5eedb4 
Should be private$filename instead of private$file
@schloerke schloerke merged commit dcc178e into rstudio:master Aug 7, 2020
schloerke added a commit that referenced this pull request Aug 7, 2020
@schloerke
Merge branch 'master' into json_first_byte
1c7f833 
* master:
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
schloerke added a commit that referenced this pull request Aug 7, 2020
@schloerke
Merge branch 'master' into parser_octect_structure
0b213a6 
* master:
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
schloerke added a commit that referenced this pull request Aug 7, 2020
@schloerke
Merge branch 'master' into validate_openapi
d5b90d4 
* master:
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
schloerke added a commit that referenced this pull request Aug 7, 2020
@schloerke
Merge branch 'master' into multiple_matched_args
1553772 
* master:
  `parser_octet()` returns a named list of filename to content (#636)
  Add `validate_api_spec()` (#633)
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meztez @schloerke