Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate_api_spec() #633

Merged
merged 13 commits into from
Aug 7, 2020
Merged

Add validate_api_spec() #633

merged 13 commits into from
Aug 7, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 7, 2020 •
edited
Loading

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()
  • Adds validate_api_spec()
  • Caches npm install in the R temp dir
  • Only requires node and npm (installed with node)
  • Run validations on all example plumber apis

@schloerke
default requestBody to be NULL
48589b4
@schloerke
validate openapi examples on mac - GHA
4c9beca
@schloerke
Merge branch 'master' into validate_openapi
d2d1d5f 
* master:
  Add `plumb_api()` and `available_apis()` (#631)
  Allow serializers to return hooks and a serializer function. Port all image serializers to use new functionality (#630)
@schloerke
Add validate_api()
a5ae046 
* Validate on all platforms
* Cache the npm install
* fix examples to be valid OAS
@schloerke
remove comment
6743b95
@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 7, 2020
@schloerke schloerke changed the title Add validate_api() Add validate_api_spec() Aug 7, 2020
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 7, 2020
View reviewed changes
R/validate_api_spec.R Outdated Show resolved Hide resolved
cpsievert
cpsievert approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

schloerke and others added 5 commits August 7, 2020 15:31
@schloerke
Merge branch 'master' into validate_openapi
d5b90d4 
* master:
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
@schloerke @cpsievert
Make install location a function
98fc7e1 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke @cpsievert
Wording
2e04511 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke @cpsievert
Only use npm, no need to check for yarn
d9fb669 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke
add a verbose arg to validate_api_spec(). Use crayon to display text
d903cae
@schloerke schloerke merged commit 2bc1835 into master Aug 7, 2020
@schloerke schloerke deleted the validate_openapi branch August 7, 2020 20:32
schloerke added a commit that referenced this pull request Aug 7, 2020
@schloerke
Merge branch 'master' into multiple_matched_args
1553772 
* master:
  `parser_octet()` returns a named list of filename to content (#636)
  Add `validate_api_spec()` (#633)
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
@schloerke schloerke mentioned this pull request Aug 20, 2020
Closed
@schloerke schloerke mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @cpsievert