Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate_api_spec() #633

Merged
merged 13 commits into from Aug 7, 2020
Merged

Add validate_api_spec() #633

merged 13 commits into from Aug 7, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 7, 2020

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()
  • Adds validate_api_spec()
  • Caches npm install in the R temp dir
  • Only requires node and npm (installed with node)
  • Run validations on all example plumber apis

schloerke added 5 commits Aug 6, 2020
* master:
  Add `plumb_api()` and `available_apis()` (#631)
  Allow serializers to return hooks and a serializer function. Port all image serializers to use new functionality (#630)
* Validate on all platforms
* Cache the npm install
* fix examples to be valid OAS
@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 7, 2020
@schloerke schloerke changed the title Add validate_api() Add validate_api_spec() Aug 7, 2020
@schloerke schloerke requested a review from cpsievert Aug 7, 2020
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
R/validate_api_spec.R Outdated Show resolved Hide resolved
tests/testthat/test-openapi.R Outdated Show resolved Hide resolved
Copy link
Contributor

@cpsievert cpsievert left a comment

LGTM with suggestions

schloerke and others added 5 commits Aug 7, 2020
* master:
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke schloerke merged commit 2bc1835 into master Aug 7, 2020
1 check passed
@schloerke schloerke deleted the validate_openapi branch Aug 7, 2020
schloerke added a commit that referenced this pull request Aug 7, 2020
* master:
  `parser_octet()` returns a named list of filename to content (#636)
  Add `validate_api_spec()` (#633)
  Add another situation for no context JSON post body (#635)
  fix dockerfile extra buildargs
  Misnamed properties private$filename (#638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants