Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializer_write_file() and add to some news entries #660

Merged
merged 14 commits into from
Aug 27, 2020
Merged

Add serializer_write_file() and add to some news entries #660

merged 14 commits into from
Aug 27, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 24, 2020 •
edited by cpsievert
Loading

  • Expand on some news items
  • Fix warning produced in test
  • Add serializer_write_file()

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 24, 2020
@schloerke schloerke changed the title Minor feedback tweaks Add serializer_tmp_file() and add to some news entries Aug 24, 2020
cpsievert
cpsievert reviewed Aug 25, 2020
View reviewed changes
R/serializer.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 25, 2020
View reviewed changes
R/serializer.R Outdated Show resolved Hide resolved
@schloerke schloerke changed the title Add serializer_tmp_file() and add to some news entries Add serializer_write_file() and add to some news entries Aug 27, 2020
cpsievert
cpsievert reviewed Aug 27, 2020
View reviewed changes
R/content-types.R Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Aug 27, 2020
View reviewed changes
R/serializer.R Outdated Show resolved Hide resolved
@schloerke @cpsievert
Apply suggestions from code review
cfb8826 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@schloerke schloerke merged commit 1408394 into master Aug 27, 2020
@schloerke schloerke deleted the tweaks branch August 27, 2020 20:32
schloerke added a commit that referenced this pull request Sep 1, 2020
@schloerke
Merge branch 'master' into rc-v1.0.0
ae9db47 
* master:
  Multipart body followup (#667)
  Copy in properly sized png logo
  Multipart Body parsing (#663)
  Add `serializer_write_file()` and add to some news entries (#660)
  Update logos to include a url. Add hex submitted to rstudio/hex-stickers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @cpsievert