Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipart body followup #667

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Multipart body followup #667

merged 2 commits into from
Sep 1, 2020

Conversation

schloerke
Copy link
Collaborator

Related: #663

  • Make it so req_body_parser doesn't set info in req and also return a value

PR task list:

  • [NA] Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Sep 1, 2020
@schloerke schloerke changed the title multipart body followup Multipart body followup Sep 1, 2020
cpsievert
cpsievert approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass

@schloerke schloerke merged commit bb1d54e into master Sep 1, 2020
@schloerke schloerke deleted the multi_part_body_followup branch September 1, 2020 20:50
schloerke added a commit that referenced this pull request Sep 1, 2020
@schloerke
Merge branch 'master' into postBody_delay
da8d88e 
* master:
  Multipart body followup (#667)
  Copy in properly sized png logo
schloerke added a commit that referenced this pull request Sep 1, 2020
@schloerke
Merge branch 'master' into rc-v1.0.0
ae9db47 
* master:
  Multipart body followup (#667)
  Copy in properly sized png logo
  Multipart Body parsing (#663)
  Add `serializer_write_file()` and add to some news entries (#660)
  Update logos to include a url. Add hex submitted to rstudio/hex-stickers
schloerke added a commit that referenced this pull request Sep 1, 2020
@schloerke
Merge branch 'master' into exec_req_res
3d0f310 
* master:
  Multipart body followup (#667)
  Copy in properly sized png logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @cpsievert