decode static URI before serving #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking of creating the file on the flies for the test. Since I get an R check error for the filename. |
|
Will need to check if file exists as some systems won't be able to write chinese characters. 😞 Or maybe skip on cran and only test on macos? Then the logic will at least be tested inside GHA. |
|
I'll wait to see which one fails |
|
so skip on CRAN |
schloerke
added a commit
that referenced
this pull request
Jun 2, 2022
* main: Fix Content-Length header on HTTP responses which forbid it (#760) Generate docs and fix existing tests (#860) decode static URI before serving (#754) Update feather serializer; Add parquet serializer (#849) remove author in pkgdown; have website build again Fix plumber website. Use tidytemplate (#851) Runtime Vignette typo (#848) GHA v2 (#842) master -> main (#839) Create GeoJSON serializer and parser (#830) Add details about named functions as router modifiers (#824) Parser params should be in a `list()` (#827) Test on ubuntu 18/20 and use relative R versions (#828) Shared secret rejections are not errors (#809) Fix tag endpoint block annotation spelling to `@tag` (#800) Add ORCID info (#794) Add blog post link to website (#792) Use serializer Content-Type header for PlumberEndpoint API spec (#789) Use dev version (#790) v1.1.0 (#752)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #753
PR task list:
devtools::document()