-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared secret rejections are not errors #809
Conversation
Thanks @aronatkins! |
What should be the http status of these? |
From Lines 38 to 40 in e846cb3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending suggestion
(Windows devel is unrelated to failure)
(Please squash+merge when ready)
Co-authored-by: Barret Schloerke <barret@rstudio.com>
572a738
to
e467824
Compare
Thank you for the tests @aronatkins! |
* main: Fix Content-Length header on HTTP responses which forbid it (#760) Generate docs and fix existing tests (#860) decode static URI before serving (#754) Update feather serializer; Add parquet serializer (#849) remove author in pkgdown; have website build again Fix plumber website. Use tidytemplate (#851) Runtime Vignette typo (#848) GHA v2 (#842) master -> main (#839) Create GeoJSON serializer and parser (#830) Add details about named functions as router modifiers (#824) Parser params should be in a `list()` (#827) Test on ubuntu 18/20 and use relative R versions (#828) Shared secret rejections are not errors (#809) Fix tag endpoint block annotation spelling to `@tag` (#800) Add ORCID info (#794) Add blog post link to website (#792) Use serializer Content-Type header for PlumberEndpoint API spec (#789) Use dev version (#790) v1.1.0 (#752)
This change has the shared secret filter no longer log an error and returns a cleaner error response.
Fixes #808
CC @blairj09