Update parquet parser #855
Conversation
|
|
| if (!requireNamespace("readr", quietly = TRUE)) { | ||
| stop("`readr` must be installed for `parser_parquet` to work") | ||
| } | ||
| readr::write_file(value, tmpfile) |
There was a problem hiding this comment.
What advantage is there to use readr::write_file() over writeBin()?
There was a problem hiding this comment.
Do you have an example of a rare issue?
There was a problem hiding this comment.
I was trying to write a test to for the issue (I thought) I was having with the writeBin implementation. The original data I was having this issue (#854) with is not public, and some alternatives I've tried didn't seem to reproduce either.
I've just gone back to the machine I was trying this on, and it doesn't reproduce there either -- I think this must've been caused by something else. I'll close this PR for now.
|
@Giqles Any other changes you'd like to do to make this PR not a draft? |
|
Closing this for now. Does not reproduce consistently. |
This is a fix for #854.
# insert reprex herePR task list:
devtools::document()