Quick Install Script #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glin
reviewed
Sep 6, 2019
There was a problem hiding this comment.
Sorry it took a while to look at this - but this is really nice! Much easier to install without having to look at that versions.json file, define an R version variable, etc.
I noticed two minor issues with R 3.6.1 not showing up and the Science repo being installed on openSUSE, but otherwise this looks great.
…k_install Takes version as 2nd arg, R versions, help and version CLI switches, silent json fetch
|
@glin I merged @ricardofandrade's improvements into this branch and made a few changes based on your feedback. |
glin
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
The latest changes (+@ricardofandrade's suggestions) look good to me
Co-Authored-By: Ricardo Andrade <ricardofandrade@users.noreply.github.com>
Co-Authored-By: Ricardo Andrade <ricardofandrade@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quick install script to help ease installation. Before we merge this, we should:
https://rstd.io/r-installthat points to the newinstall.shscript.To test, since
https://rstd.io/r-installpoints to a location (master) that doesn't yet exist, you can use this one-liner:bash -c "$(curl -L https://raw.githubusercontent.com/rstudio/r-builds/jon/quick-install/install.sh)"