Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix V8 on Fedora 38 #122

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fix V8 on Fedora 38 #122

merged 1 commit into from
Jan 31, 2023

Conversation

gaborcsardi
Copy link
Collaborator

They have two versions of V8 now, this is one of them.

@gaborcsardi
Fix V8 on Fedora 38
c92a204 
They have two versions of V8 now.
@gaborcsardi gaborcsardi requested a review from glin January 29, 2023 12:00
@gaborcsardi gaborcsardi merged commit fe0a563 into rstudio:main Jan 31, 2023
@gaborcsardi gaborcsardi deleted the fix/fedora-38-v8 branch January 31, 2023 22:17
@gaborcsardi
Copy link
Collaborator Author

@glin: Thanks!

@jeroen
Copy link
Contributor

jeroen commented Feb 4, 2023 •
edited
Loading

What is the other version? Afaict v8-devel is an alias for v8-10.2-devel ?

@gaborcsardi
Copy link
Collaborator Author 

> dnf search v8
...
v8-10.2-devel.aarch64 : v8 - development headers
v8-9.4-devel.aarch64 : v8 - development headers
...

Yeah, it is an alias (or whatever they call it), but the way we run the tests does not seem to find it:

[root@d3b7b4045985 ~]# yum -C list -q v8-devel
Error: No matching Packages to list

There is probably a way to query this with dnf or yum, but IDK how.

@jeroen
Copy link
Contributor

jeroen commented Feb 4, 2023

@sgallagher is this expected? Is there a way to automatically resolve v8-devel to the default one from the current distro?

@sgallagher
Copy link 

[sgallagh@toolbox ~]$ yum repoquery --whatprovides v8-devel
Fedora rawhide openh264 (From Cisco) - x86_64                                                                                                                                        2.3 kB/s | 2.5 kB     00:01    
Fedora - Rawhide - Developmental packages for the next Fedora release                                                                                                                 19 MB/s |  66 MB     00:03    
Fedora - Modular Rawhide - Developmental packages for the next Fedora release                                                                                                        1.7 MB/s | 2.3 MB     00:01    
v8-10.2-devel-3:10.2.154.23-1.18.13.0.8.fc38.i686
v8-10.2-devel-3:10.2.154.23-1.18.13.0.8.fc38.x86_64
v8-9.4-devel-3:9.4.146.26-1.16.19.0.1.fc38.i686
v8-9.4-devel-3:9.4.146.26-1.16.19.0.1.fc38.x86_64

If I do dnf install v8-devel, it (correctly) gets v8-10.2-devel.

In theory, I could remove the Provides: v8-devel = %{v8_epoch}:%{v8_version}-%{v8_release} from the non-default one, but I don't know if that's the best approach.

FTR, yum list only lists the actual package names, not its virtual Provides. You should use the repoquery command I noted above, which will search all provided names.

@gaborcsardi
Copy link
Collaborator Author

Thank you!

Changed back to the alias here: #123

@jeroen jeroen mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glin glin glin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaborcsardi @jeroen @sgallagher @glin