Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renv::update() ignores renv::settings$ignored.packages. #425

Closed
vspinu opened this issue May 12, 2020 · 4 comments
Closed

renv::update() ignores renv::settings$ignored.packages. #425

vspinu opened this issue May 12, 2020 · 4 comments

Comments

@vspinu
Copy link

vspinu commented May 12, 2020

If I do renv::settings$ignored.packages("purrr") and then renv::update(), purr is still updated. Is there a way to freeze a package when others are updated?

I think renv::update(exclude = "...") would be useful in cases when a small set of packages should stay.

@vspinu
Copy link
Author

vspinu commented May 12, 2020

BTW, ignoring packages seems to be broken. If my package is ignored and it's in renv.lock file, then when I do renv::snapshot() I get:

The following required packages are not installed:

	xyz [required by abc]

Consider re-installing these packages before snapshotting the lockfile.

Re-installing doesn't work, same message.

@kevinushey
Copy link
Collaborator

Assuming I'm understanding the second issue, it sounds like you're trying to ignore a package that is required by another package. Is that correct?

If so, I think the issue here is in the error message -- the ignored package should still be omitted from the lockfile, but the diagnostic work that runs beforehand is flagging xyz because it's "required" but not available (because it was ignored)

@vspinu
Copy link
Author

vspinu commented May 12, 2020

That's right. The package is required by another package, and I want to freeze the dependency.

@kevinushey
Copy link
Collaborator

I believe this is fixed now on master -- let me know if that doesn't appear to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants