Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt=TRUE does nothing #587

Closed
nick-youngblut opened this issue Dec 3, 2020 · 2 comments · Fixed by #1374
Closed

prompt=TRUE does nothing #587

nick-youngblut opened this issue Dec 3, 2020 · 2 comments · Fixed by #1374
Labels
feature a feature request or enhancement install 🧺

Comments

@nick-youngblut
Copy link

renv::install(..., prompt=TRUE) does nothing. renv just installs all packages without any confirmation. I'm surprised "install regardless of the version changes to existing packages" is the default in R. That's the opposite of conda, which defaults to prompting the user after listing all proposed changes to the existing environment. It would be great to have the same with renv.

> sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: Ubuntu 18.04.5 LTS

Matrix products: default
BLAS/LAPACK: /ebio/abt3_projects/Georg_animal_feces/envs/function/lib/libopenblasp-r0.3.10.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] renv_0.12.3

loaded via a namespace (and not attached):
[1] compiler_4.0.3 tools_4.0.3
@hadley hadley added feature a feature request or enhancement install 🧺 labels Apr 28, 2023
@hadley
Copy link
Member

hadley commented May 30, 2023

prompt only has any effect if the preflight checks fail, i.e. if any of the packages have an unknown source or the library isn't writeable.

@kevinushey do you think it should behave similarly to restore() here? Or is this something we want to leave for the pak work?

@kevinushey
Copy link
Collaborator

IMHO we should be prompting before installation (as restore() does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement install 🧺
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants