-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand PPM platform support #1728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the /etc/os-issue
from an amazonlinux2 container
docker run -it --rm amazonlinux:2 cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
SUPPORT_END="2025-06-30"
Does this change (and the one in #1716) need NEWS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'd prefer keeping these separate just for clarity, even if it means some code is duplicated here. |
Yeah, agreed 👍🏻 |
Fixes #1720
I set out to add support for getting Rocky Linux 9 binaries from Package Manager instances, as it's binary compatible with CentOS/RHEL binaries. This was initially motivated by adding binary support for Connect instances hosted on Rocky. Along the way I went to check out
/etc/os-release
files from other supported distros, and made some other additions/fixes.Connect's supported distros are listed here, and Package Manager's are available here.
Changes I made:
centos8
/rhel9
.renv
to support it.) Itsplatform
function is like Ubuntu.renv_ppm_platform_suse()
function would return something likeopensuse15
, but the minor part of the version needs to be appended, e.g.opensuse154
. Also, OpenSUSE/etc/os-release
files don't always containsuse
as a standalone word, so the I changed the regex used to identify this distro./etc/os-release
files from OpenSUSE.Other changes I'm considering, and would appreciate feedback on whether to include or not:
centos7
. It seems to be mostly compatible (StackOverflow, Amazon docs), and I think this is the basis of Connect listing it as supported, but I'm not sure.Code style questions:
renv_ppm_platform_rhel
for AlmaLinux and Rocky.\\bsuse\\b
in theID_LIKE
field instead of directly looking for theID
field.