Update tests following Pandoc change in 2.18 #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id are added to TOC element now which produce raw HTML link in markdown
|
I need to wait for next Pandoc version to fix this so that I can test the version - currently Pandoc nightly build have the same version number than last release so that does not help. I may need to reconsider also how we do snapshot testing for several pandoc versions 🤔 |
|
I have disabled Pandoc daily checks waiting for this to be fixed |
|
This should work now but nightly build of Pandoc is failing (https://github.com/jgm/pandoc/actions/runs/2094759820), so the nightly version installed is not yet 2.18. I'll merge and this should solve by itself |
cderv
changed the title
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
May 5, 2022
* jg-devel: use tufte::tufte_handout in test, and remove tufte_handout in doc mark tufte_handout() as defunct CRAN release v2.14 typo in NEWS Update arrow.theme regarding accessibility Adapt test snapshots to last pandoc devel 2.18+ (rstudio#2349) Revert "remove from NEWS as pandoc devel reverted the change" remove from NEWS as pandoc devel reverted the change Support for `fold-none` class in `html_document()` (rstudio#2348) Support new scheme for Pandoc nightly build Add lua-based codefolding feature and apply it to html_vignette (rstudio#2340) `site_generator()` stops search at RStudio project root (rstudio#2345) Update CONTRIBUTING.md Update tests following Pandoc change in 2.18 (rstudio#2334) dirname('.') returns '.', which will cause infinite recursion, so normalize the relative path to absolute before the next recursion (fix rstudio#2339) Fix parsing by pandoc of last paragraph in shinyrmd doc (rstudio#2337)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id are added to TOC element now which produce raw HTML link in markdown
Close #2306
I got no anwser on Pandoc discuss so I guess this change is here to stay.
This should fix the CI then