Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fold-none chunk option to opt-out code folding from individual chunks in html_document #2348

Merged
merged 8 commits into from Apr 12, 2022
Merged

Add fold-none chunk option to opt-out code folding from individual chunks in html_document #2348

merged 8 commits into from Apr 12, 2022

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Apr 11, 2022

solves #2346

  • implement fold-none option
  • update documents
  • devtools::document()

yihui
yihui approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

R/html_document.R Outdated Show resolved Hide resolved
@yihui yihui requested a review from cderv April 11, 2022 19:23
@atusy
Copy link
Contributor Author

atusy commented Apr 11, 2022

@yihui Thanks. I added spaces to other @-marks, too.

cderv
cderv approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks !

@cderv
Bump version
6f008e1 
[skip ci]
@cderv cderv linked an issue Apr 12, 2022 that may be closed by this pull request
[FR] Add fold-none chunk option to opt-out code folding from individual chunks in html_document #2346
Closed
@cderv cderv merged commit fd691ff into rstudio:main Apr 12, 2022
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this pull request May 5, 2022
@jonathan-g
Merge branch 'jg-devel'
acd53a3 
* jg-devel:
  use tufte::tufte_handout in test, and remove tufte_handout in doc
  mark tufte_handout() as defunct
  CRAN release v2.14
  typo in NEWS
  Update arrow.theme regarding accessibility
  Adapt test snapshots to last pandoc devel 2.18+ (rstudio#2349)
  Revert "remove from NEWS as pandoc devel reverted the change"
  remove from NEWS as pandoc devel reverted the change
  Support for `fold-none` class in `html_document()` (rstudio#2348)
  Support new scheme for Pandoc nightly build
  Add lua-based codefolding feature and apply it to html_vignette (rstudio#2340)
  `site_generator()` stops search at RStudio project root (rstudio#2345)
  Update CONTRIBUTING.md
  Update tests following Pandoc change in 2.18 (rstudio#2334)
  dirname('.') returns '.', which will cause infinite recursion, so normalize the relative path to absolute before the next recursion (fix rstudio#2339)
  Fix parsing by pandoc of last paragraph in shinyrmd doc (rstudio#2337)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
R Markdown Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Add fold-none chunk option to opt-out code folding from individual chunks in html_document
3 participants
@atusy @yihui @cderv