Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore project-local python virtual environments by default #632

Closed
edavidaja opened this issue Nov 4, 2022 · 2 comments · Fixed by #700
Closed

ignore project-local python virtual environments by default #632

edavidaja opened this issue Nov 4, 2022 · 2 comments · Fixed by #700
Labels
bug an unexpected problem or unintended behavior manifest 📝 python 🐍

Comments

@edavidaja
Copy link

An internal user encountered the following while attempting to deploy a reticulated project:

Error in enforceBundleLimits(appDir, files$totalSize, length(files$contents)) : 
  The directory /usr/home/jeremy.allen/projects/reticulate-with-venv cannot be deployed because it contains too many files (the maximum number of files is 10000). Remove some files or adjust the rsconnect.max.bundle.files option.`

you can work around this by adjusting the max bundle files or by specifying appFiles but ignoring the files to begin with might be a better default.

@hadley hadley added bug an unexpected problem or unintended behavior python 🐍 labels Feb 21, 2023
@hadley
Copy link
Member

hadley commented Feb 21, 2023

What directories do we need to ignore?

@edavidaja
Copy link
Author

The Python command line interface ignores some conventional names for virtual environment directories: https://github.com/rstudio/rsconnect-python/blob/master/rsconnect/bundle.py#L37-L50
and checks for directories that are likely to contain a virtual environment:
https://github.com/rstudio/rsconnect-python/blob/94dbd28797ee503d66411f736da6edc29fcf44ed/rsconnect/bundle.py#L541-L543

hadley added a commit that referenced this issue Feb 23, 2023
@hadley hadley closed this as completed in 2a578e5 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior manifest 📝 python 🐍
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants