Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if package versions are newer than those on CRAN #659

Closed
hadley opened this issue Feb 8, 2023 · 0 comments · Fixed by #670 or #781
Closed

Warn if package versions are newer than those on CRAN #659

hadley opened this issue Feb 8, 2023 · 0 comments · Fixed by #670 or #781
Labels
dependencies 🐀 feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Feb 8, 2023

Fixes the problem I have

Add something to

rsconnect/R/bundle.R

Lines 694 to 695 in 9c93300

# validate package source (returns a message if there is a problem)
packageMessages <- c(packageMessages, validatePackageSource(deps[i, ]))

@hadley hadley mentioned this issue Feb 14, 2023
Merged
@hadley hadley added dependencies 🐀 feature a feature request or enhancement labels Feb 21, 2023
@hadley hadley mentioned this issue Feb 21, 2023
Closed
@hadley hadley reopened this Feb 26, 2023
hadley added a commit that referenced this issue Mar 17, 2023
@hadley
Improve package standardization
df2f5d7 
There were a lot of layers to unpeel here, but I think I've got to a place where the code both does what we want (including thinking about archived packages) and is easy to reason about.

Fixes #659
@hadley hadley mentioned this issue Mar 17, 2023
Merged
hadley added a commit that referenced this issue Mar 20, 2023
@hadley
Improve package standardization (#781)
82a5f36 
This turned into a pretty comprehensive rewrite that makes the parallels to the packrat implementation clearer, and extracts out functions to make testing much easier. Most importantly, we're now confident enough about our package processing to turn problems into an error, rather than a warning, meaning that you should get a useful error message sooner. 

Fixes #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies 🐀 feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor bundlePackages() rstudio/rsconnect
Improve package standardization rstudio/rsconnect
1 participant
@hadley