Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More information from deployApp() #669

Closed
hadley opened this issue Feb 14, 2023 · 0 comments · Fixed by #718
Closed

More information from deployApp() #669

hadley opened this issue Feb 14, 2023 · 0 comments · Fixed by #718
Labels
feature a feature request or enhancement logging 🌳

Comments

@hadley
Copy link
Member

hadley commented Feb 14, 2023 •
edited
Loading

  • If appFiles not specified, output which files are uploaded
  • In deploymentTarget() output if using existing deployment (with appId) or if it's new. Might be worth outputting fully reified account + server. And need appTitle too. Maybe createDeploymentTarget() should report everything if verbose?

For QA, need to use that information to verify a few publishing workflows to make sure that we don't clash with how the IDE sets values. Need to check both new, republish, and "other destination" workflows.
@hadley hadley mentioned this issue Feb 14, 2023
Merged
@hadley hadley added logging 🌳 feature a feature request or enhancement labels Feb 21, 2023
@hadley hadley mentioned this issue Feb 21, 2023
Merged
hadley added a commit that referenced this issue Feb 28, 2023
@hadley
Improve output from deployApp()
1074287 
* Add some bigger structure with `cli::cat_rule()`
* Inform about appName and destination
* Don't display bundle/application ID so many times
* List uploaded files
* Strip timestamps from connect logs, highlight headings, and display on stdout, not stderr

Fixes #669

*
@hadley hadley mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement logging 🌳
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve output from deployApp() rstudio/rsconnect
1 participant
@hadley