preserve explicit renv dependency

[aronatkins]

Given the Shiny application

library(shiny)
library(rsconnect)

ui <- fluidPage("hello")
server <- function(input, output) {}

shinyApp(ui = ui, server = server)

The renv package is not included in the set of required packages due to:

rsconnect/R/bundlePackageRenv.R

Lines 74 to 77 in e7a434a

	# Don't include renv itself
	if (identical(pkg$Package, "renv")) {
	return(NULL)
	}

packageVersion("rsconnect")
#> [1] '1.0.0'
packageVersion("renv")
#> [1] '1.0.0'
rsconnect::writeManifest()
#> ℹ Capturing R dependencies with renv
#> Warning in is.na(value): is.na() applied to non-(list or vector) of type
#> 'language'
#> Error in if (is.na(value)) default else as.logical(value): the condition has length > 1
manifest <- jsonlite::read_json("manifest.json")
manifest$packages$rsconnect$description$Imports
#> [1] "cli, curl, digest, jsonlite, lifecycle, openssl (>= 2.0.0),\npackrat (>= 0.6), renv (>= 1.0.0), rlang (>= 1.0.0), rstudioapi\n(>= 0.5), tools, yaml (>= 2.1.5)"
manifest$packages$renv
#> NULL

^{Created on 2023-07-18 with reprex v2.0.2}

[aronatkins]

Workaround: Fall back to use packrat for dependency detection (which internally uses renv::dependencies and does not have an renv dependency removed).

options(rsconnect.packrat = TRUE)

[aronatkins]

This issue highlights a difference between renv and packrat: we could disable the implicit packrat dependency.

rsconnect/R/bundlePackagePackrat.R

Lines 179 to 185 in e7a434a

	packrat::.snapshotImpl(
	project = bundleDir,
	snapshot.sources = FALSE,
	fallback.ok = TRUE,
	verbose = verbose,
	implicit.packrat.dependency = FALSE
	)

[aronatkins]

This issue may be causing folks problems out in the wild, as reported here: https://stackoverflow.com/questions/76711093/missing-dependency-from-rsconnect-when-deploying-shinyapps/76715457#76715457