Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow app-mode override #948

Closed
aronatkins opened this issue Aug 11, 2023 · 1 comment · Fixed by #953
Closed

allow app-mode override #948

aronatkins opened this issue Aug 11, 2023 · 1 comment · Fixed by #953
Assignees

Comments

@aronatkins
Copy link
Contributor

Let the caller override the inferred type of content.

Separated from #942.

@dragonstyle
Copy link

Thanks for opening this.

I think this fix is essential as this provides a way for a caller to control the type of content without relying on inference (which can't anticipate all possible deployment scenarios that callers could create).

Quarto Manuscript publishing to connect is broken in RStudio until this issue, or some other workaround is discovered, though @hadley and I reviewed the issues and concluded this was likely to be the best fix.

@aronatkins aronatkins mentioned this issue Aug 14, 2023
17 tasks
@aronatkins aronatkins self-assigned this Aug 14, 2023
aronatkins added a commit that referenced this issue Aug 14, 2023
Allow override of the inferred `appMode` for situations where complicated
deployments can lead to incorrectly inferred content type. For example, the
presence of an `app.R` forces the content to be deployed as a Shiny
application with the `appMode = "shiny"` even if that file was an auxiliary
resource for some other type of content that happens to have lower precedence.

The appMode argument is accepted by:
- `deployApp`
- `writeManifest`
- `listDeploymentFiles`
- `appDependencies`

The `appDependencies` function supports obtaining a set of deployment files
through `appFileManifest`.

The `appMetadata` function no longer calls `listDeploymentFiles`. It assumes
that the caller has already fully enumerated the required files and provided
them in `appFiles`.

Fixes #948
aronatkins added a commit that referenced this issue Aug 15, 2023
* appMode override

Allow override of the inferred `appMode` for situations where complicated
deployments can lead to incorrectly inferred content type. For example, the
presence of an `app.R` forces the content to be deployed as a Shiny
application with the `appMode = "shiny"` even if that file was an auxiliary
resource for some other type of content that happens to have lower precedence.

The appMode argument is accepted by:
- `deployApp`
- `writeManifest`
- `listDeploymentFiles`
- `appDependencies`

The `appDependencies` function supports obtaining a set of deployment files
through `appFileManifest`.

The `appMetadata` function no longer calls `listDeploymentFiles`. It assumes
that the caller has already fully enumerated the required files and provided
them in `appFiles`.

Fixes #948

* direction to deploy one project five ways

* enumerate the most common app-mode values from R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants