Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce bundle limits when exploding file enumerations #546

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

aronatkins
Copy link
Contributor

@aronatkins aronatkins commented Oct 19, 2021

The rsconnect.max.bundle.size and rsconnect.max.bundle.files limits are enforced both with appFiles as well as without appFiles. Previously, we would not enforce limits when appFiles or appFileManifest was given.

options(rsconnect.max.bundle.size = 10)
rsconnect::deployApp(server = "SERVER", account = "ACCOUNT", appFiles=c("app.R"))
#> Error: The directory DIRECTORY cannot be deployed because it is too large (the maximum size is 10 bytes). Remove some files or adjust the rsconnect.max.bundle.size option.
options(rsconnect.max.bundle.size = 10)
rsconnect::deployApp(server = "SERVER", account = "ACCOUNT")
#> Error: The directory DIRECTORY cannot be deployed because it is too large (the maximum size is 10 bytes). Remove some files or adjust the rsconnect.max.bundle.size option.

R/bundle.R Show resolved Hide resolved
@ChaitaC
Copy link

ChaitaC commented Oct 21, 2021

Testing notes:

  • Make sure we enforce the limit however we upload (push button, modify the files, directly deploy app, deploy in R in different ways and make sure we enforce the limit)

@aronatkins aronatkins merged commit f516612 into main Oct 27, 2021
@aronatkins aronatkins deleted the aron-explode-enforces-limits branch October 27, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants