Extract out validateConnectUrl() #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test it and resolve problem with posit.cloud * Use it in `addServer()` * Add new `addTestServer()`
aronatkins
requested changes
Mar 8, 2023
| @@ -9,6 +9,20 @@ | |||
| # the URL may be specified with or without the protocol and port; this function | |||
| # will try both http and https and follow any redirects given by the server. | |||
| validateServerUrl <- function(url, certificate = NULL) { | |||
|
|
|||
| valid <- validateConnectUrl(url, certificate) | |||
There was a problem hiding this comment.
Could we document that this function has a side-effect of registering a server if it discovers that the input URL can be transformed into a valid server?
aronatkins
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addServer()addTestServer()