Skip to content

Commit

Permalink
add comment on PathFindOnPath
Browse files Browse the repository at this point in the history
  • Loading branch information
jjallaire committed Jul 23, 2011
1 parent 955a52a commit 5facd97
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/cpp/core/system/Win32ChildProcess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,19 @@

#include "CriticalSection.hpp"

// TODO: test locating of executables
// TODO: consider whether we should do PathFindOnPath if the provided
// command isn't a full path:
// http://msdn.microsoft.com/en-us/library/bb773594(VS.85).aspx

// TODO: note on PeekNamedPipe blocking in multithreaded app with
// other blocking call to ReadFile active

// TODO: consider a peek, read, sleep loop to avoid global read block

namespace core {
namespace system {

namespace {



// close a handle then set it to NULL (so we can call this function
// repeatedly without failure or other side effects)
Error closeHandle(HANDLE* pHandle, const ErrorLocation& location)
Expand Down

0 comments on commit 5facd97

Please sign in to comment.