-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbled text / buffering issue with fast updates and colored text #4777
Comments
This alone unfortunately does not fix rstudio/rstudio#4777
This is a bug in the IDE's handling of carriage returns with a line containing different colors, and is triggered by the progress-bar output being inconsistent in length (the part before the colored text): For example, here's a subset of what is being written to the console in the third scenario, notice the difference in output length; every-time this happens the console messes up and doesn't overwrite the previous output.
|
…olor ranges Fixes #4777 I think this is reasonably safe to take for 1.2-patch. This code is finicky but does have good unit test coverage.
Fixed in 1.2-patch via 0be83fa. |
Verified in RStudio Desktop 1.2.1526 on Windows 10. |
System details
Steps to reproduce the problem
Run the following code in the RStudio console pane. The first two
show_progress()
calls should work as expected, the third generates garbled text.The same code works fine in a terminal outside of RStudio and even in a R session started in the RStudio terminal pane.
My guess is there is some sort of buffering going on in the RStudio console that is messing up the updates when they happen quickly enough.
The text was updated successfully, but these errors were encountered: