Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the have_rsa_key to true property when a ssh key is created #11188

Merged
merged 1 commit into from
May 12, 2022

Conversation

romainfrancois
Copy link
Contributor

Intent

Follow up to #11182, adresses #8255

Approach

In #11182 we updated the "rsa_key_path" property, but we also need to update the "have_rsa_key", otherwise it's only set in UserPrefsComputedLayer::readPrefs().

This PR sets it to true

Automated Tests

Indicate whether this change includes unit tests or integration tests, or link a work item or pull request to add those tests to another repo. If the change cannot or will not be covered by a test, indicate why.

QA Notes

Add additional information for QA on how to validate the change, paying special attention to the level of risk, adjacent areas that could be affected by the change, and any important contextual information not present in the linked issues.

Checklist

  • If this PR adds a new feature, or fixes a bug in a previously released version, it includes an entry in NEWS.md
  • If this PR adds or changes UI, the updated UI meets accessibility standards
  • A reviewer is assigned to this PR (if unsure who to assign, check Area Owners list)
  • This PR passes all local unit tests

Copy link
Contributor

@jgutman jgutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I didn't think of this, I was testing when starting with a key and switching key types/paths, but I didn't think to start with no keys. Thanks!!

@jgutman jgutman merged commit d6f0a7e into rstudio:main May 12, 2022
@romainfrancois romainfrancois deleted the follow_up_11182 branch May 12, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants