Add support for show parameter in jobs API to fix #2985
#2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierluraschi
changed the title
show parameter in jobs API to fix #2985
kevinushey
reviewed
Jun 12, 2018
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| # begin tracking job | |||
| .Call("rs_addJob", name, status, progressUnits, | |||
| actions, estimate, estimateRemaining, running, autoRemove, group, PACKAGE = "(embedding)") | |||
| actions, estimate, estimateRemaining, running, autoRemove, group, PACKAGE = "(embedding)", show) | |||
There was a problem hiding this comment.
Let's put show earlier in the parameter list (PACKAGE should come last)
jmcphers
reviewed
Jun 12, 2018
| @@ -90,7 +90,7 @@ public void updateJob(int type, Job job) | |||
| list_.addJob(job); | |||
|
|
|||
| // bring the pane to the front so the new job is visible | |||
| bringToFront(); | |||
| if (job.show) bringToFront(); | |||
There was a problem hiding this comment.
We should also skip firing the selection event if we aren't showing the job right away -- otherwise it'll still switch to the job if you have the pane open which probably isn't desired.
|
I'm a fan, I'd been thinking about doing something similar for jobs that are short or unlikely to want babysitting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement suggestion in #2985, what do you think, @jmcphers?