Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue discovered in multiline expr execution #3585

Closed
wants to merge 1 commit into from
Closed

fix issue discovered in multiline expr execution #3585

wants to merge 1 commit into from

Conversation

kevinushey
Copy link
Contributor

Closes #3582.

@jmcphers
Copy link
Member

jmcphers commented Oct 3, 2018

Do we need this for 1.2?

@kevinushey
Copy link
Contributor Author

I think we can live without this for v1.2.

@kevinushey kevinushey changed the base branch from master to v1.3 October 3, 2018 20:00
@kevinushey kevinushey changed the base branch from v1.3 to master October 3, 2018 20:00
@kevinushey
Copy link
Contributor Author

I tried changing the base from master to v1.3 and things went bonkers. I can just cherry-pick this to v1.3 to avoid messing up the git history.

@kevinushey
Copy link
Contributor Author

Cherry-picked to v1.3.

@kevinushey kevinushey closed this Oct 3, 2018
@valerie-rstudio valerie-rstudio deleted the bugfix/multiline-expr-fix branch January 21, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinushey @jmcphers