upgrade to Qt 5.12.0 #4015
Merged
upgrade to Qt 5.12.0 #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: not planning to merge right away (will wait for QA to give a test pass next week) |
|
Groovy! I will fire off a test build of the Windows docker image on my google compute environment. Update: succeeded; able to build new image and do a package build using the image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades RStudio to Qt 5.12.0. Some notable changes:
We now explicitly specify a platform target on macOS; targeting macOS Sierra (10.12). This appears necessary to work around some Qt bugs that seem to appear only when no macOS target is specified; at least as seen in my local development builds on Mojave.
Some of the workarounds we had included for Qt 5.11.1 are no longer necessary.