avoid invalid with/height redirects & increase maximum plot size #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rstudio#4968 for a few years
limits the maximal and minimal height and width after resize to avoid invalid sizes fixes rstudio#4968 for good
jan-glx
changed the title
jmcphers
approved these changes
Dec 12, 2019
|
Wow. That was fast. I should say that I did not actually test this. (Did expect some CI system to build it for me 😇). When will it be on https://dailies.rstudio.com/ or is there another place to get builds w/o going through the trouble myself? |
|
I tested this earlier this morning and found that the commas cause the querystring to stop concatenating after adding the width, so fixed here: After that change this patch tested fine for me. 1.3.665 should be available for you to try later today. |
|
Damn, sorry for the extra work! @self: No more blind coding! |
|
I tested this in RStudio-1.3.668 and it works :) no more |
|
Glad to hear it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4968 for a few years