stop using aria-modal property on modal dialogs #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gtritchie
commented
Jan 14, 2020
gtritchie
commented
- this property causes problems with certain screen reader / browser combinations including Safari / VoiceOver that can prevent the dialog from behing fully announced
- was seeing this happen consistently with Yes/No dialogs, and removing this fixed the problem
- article that discusses this: https://developer.paciellogroup.com/blog/2018/06/the-current-state-of-modal-dialog-accessibility/
- this property causes problems with certain screen reader / browser combinations including Safari / VoiceOver that can prevent the dialog from behing fully announced - was seeing this happen consistently with Yes/No dialogs, and removing this fixed the problem - article that discusses this: https://developer.paciellogroup.com/blog/2018/06/the-current-state-of-modal-dialog-accessibility/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.