Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copernicus to v6.4 and add missing Copernicus journal #446

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

RLumSK
Copy link
Contributor

@RLumSK RLumSK commented Nov 9, 2021

Another update of the Copernicus template (now version 6.4) and I've added a so far missing journal ("Web Ecology") to copernicus_article()

  • Update NEWS.

so far missing journal "Web Ecology" to copernicus_article()
@RLumSK
Copy link
Contributor Author

RLumSK commented Nov 9, 2021

@nuest Sorry, I forgot to ping you for this PR.

@RLumSK
Copy link
Contributor Author

RLumSK commented Nov 9, 2021

@cderv The failed CI checks do not seem to be related to my PR.

@cderv
Copy link
Collaborator

cderv commented Nov 9, 2021

Yes I agree. It seems to be from the Glossa format.

our test suites runs every format for now. It would be interesting to only test the modified format for PR 🤔

@RLumSK
Copy link
Contributor Author

RLumSK commented Nov 9, 2021

@cderv Thanks for the prompt response. For what it is worth, I have tested the modified version, only the Copernicus template, manually on my computer (macOS 11.6.1, pandoc 2.16.1, R 4.1.1). No problem here, but perhaps this is not a replacement for the full tests you run.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall apart from a comment I left above.

After you answer and possibly change, we are good to merge

NEWS.md Outdated Show resolved Hide resolved
@cderv cderv changed the title Update Copernicus template to version 6.4 + add missing Copernicus journal Update Copernicus to v6.4 and add missing Copernicus journal Nov 25, 2021
@cderv cderv merged commit 99429bd into rstudio:master Nov 25, 2021
@RLumSK
Copy link
Contributor Author

RLumSK commented Nov 25, 2021

@cderv Thanks for your support and the critical PR review! You raised an important point I had overlooked, at least now we have tested that and I can keep an eye on it, in case it causes some problems in the future.

@RLumSK RLumSK deleted the Copernicus_Template_Update_6_4 branch March 30, 2022 09:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants