Update PLOS template to version 3.5 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test for the PLOS template.
yihui
requested changes
Nov 21, 2018
There was a problem hiding this comment.
Thanks!
Cc @BlackEdder (#109): does this PR look good to you?
|
Except for the needed comma, the PR looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
Add the
journalname_article()function toR/journalname_article.R. If the article needs CSL to process citations, see the functionacm_article()for an example; otherwise seeasa_article()for an example. If you don't know what CSL means, see the latter.Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname_article/resources/template.tex.Add a skeleton article
inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd.Add a description of the template
inst/rmarkdown/templates/journalname_article/template.yaml.Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN.Update Rd and namespace (could be done by
devtools::document()).Update NEWS.
Update README with a link to the newly supported journal.
Add a test to
tests/testit/test-formats.R.Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Thank you!