Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSS template by pinning the version of latexrelease package #337

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Oct 16, 2020

Same fix as in 36f461d by pining the latexrelease package to older version (https://topanswers.xyz/tex?q=1416)

This should close #329 and fix the travis build #335 (comment)

let's see what travis think of that

36f461d

By pining the latexrelease package to older version (https://topanswers.xyz/tex?q=1416)
@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

So the fix indeed work for the branch : https://travis-ci.org/github/rstudio/rticles/builds/736422869

That is good to know we can pin some packages waiting for fixes upstream. I think doing that is enough and we don't need to pin the TinyTeX binary version. What do you think ?

I guess the other workflow will suceed, it is just long to run

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll revert 1054e2b and merge this one. We should also notify JSS editors about this.

@yihui yihui merged commit 13c7d68 into master Oct 16, 2020
yihui added a commit that referenced this pull request Oct 16, 2020
@yihui yihui deleted the temp-fix-for-jjs branch October 16, 2020 17:08
@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

We should also notify JSS editors about this.

Do you have a specific contact or should we write to https://www.jstatsoft.org/about/contact ?

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

And maybe we need to cache again... 😞
We still get the "no output timeout" from travis, and builds are taking ~30min each...
https://travis-ci.org/github/rstudio/rticles/jobs/736438003#L2351

Other idea: maybe we should build a binary specific from rticles testing ?

@yihui
Copy link
Member

yihui commented Oct 16, 2020

Do you have a specific contact or should we write to https://www.jstatsoft.org/about/contact ?

Just write to that email.

Other idea: maybe we should build a binary specific from rticles testing ?

Let's try to figure out which packages are necessary (calculate the setdiff() for tinytex::tl_pkgs() before and after testing rticles, based on a fresh install of TinyTeX), and tlmgr install them in the before_install step.

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

OK I'll do that ! Thanks !

@yihui
Copy link
Member

yihui commented Oct 16, 2020

We really need a way to install packages in TeX Live like the mechanism of R's .libPaths(). I searched and tried a few weeks ago, but didn't figure it out. If that is possible, we only need to cache a package directory instead of the whole TinyTeX installation. I'll ask TeX Live developers later.

@cderv
Copy link
Collaborator Author

cderv commented Oct 16, 2020

Oh yes that would be great. I have thought about it but I did not look into that yet as you said you would. That would solve issue with CI and latex dependencies for sure.

@yihui
Copy link
Member

yihui commented Oct 19, 2020

I'll ask TeX Live developers later.

I've asked them and unfortunately the answer is no, but one of them said this was an interesting idea.

@cderv
Copy link
Collaborator Author

cderv commented Oct 19, 2020

Oh too bad ! Thanks for asking. That prevent me for spending some time on this question. Glad they find that interesting ! We may see that appear one day then. For now, we will do without.

cderv added a commit that referenced this pull request Dec 15, 2020
This reverts commit 13c7d68 as now it
has be fixed upstream in jss.cls
@cderv cderv mentioned this pull request Dec 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSS article throw error upon knitting
2 participants