Skip to content

Commit

Permalink
Avoid port 6697. Closes #1784
Browse files Browse the repository at this point in the history
  • Loading branch information
wch committed Aug 28, 2017
1 parent 4f3d26c commit 4fa2af7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ shiny 1.0.5.9000

* The version of Shiny is now accessible from Javascript, with `Shiny.version`. ([#1826](https://github.com/rstudio/shiny/pull/1826))

* Addressed [#1784](https://github.com/rstudio/shiny/issues/1784): `runApp()` will avoid port 6697, which is considered unsafe by Chrome.

### Bug fixes

### Library updates
Expand Down
3 changes: 2 additions & 1 deletion R/server.R
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,8 @@ runApp <- function(appDir=getwd(),
port <- p_randomInt(3000, 8000)
# Reject ports in this range that are considered unsafe by Chrome
# http://superuser.com/questions/188058/which-ports-are-considered-unsafe-on-chrome
if (!port %in% c(3659, 4045, 6000, 6665:6669)) {
# https://github.com/rstudio/shiny/issues/1784
if (!port %in% c(3659, 4045, 6000, 6665:6669, 6697)) {
break
}
}
Expand Down

0 comments on commit 4fa2af7

Please sign in to comment.