-
Notifications
You must be signed in to change notification settings - Fork 1.9k
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bug with dateRangeInput when plotting sankeyNetworks from networkD3 package #2349
Comments
alandipert
added a commit
that referenced
this issue
Mar 21, 2019
* bootstrap-datepicker assumed the presence of only one 'body' tag on the page (document.body), and relied on the jQuery selector string 'body' to find it and use it as a container for the picker popup box * SVGs generated by networkD3 (and likely SVGs from elsewhere) break that assumption as they may contain multiple 'body' tags, which caused the picker popup box to be mismanaged and invisible * The fix was to make the body selector more specific: 'body:first' did the job.
alandipert
added a commit
that referenced
this issue
Mar 21, 2019
* bootstrap-datepicker assumed the presence of only one 'body' tag on the page (document.body), and relied on the jQuery selector string 'body' to find it and use it as a container for the picker popup box * SVGs generated by networkD3 (and likely SVGs from elsewhere) break that assumption as they may contain multiple 'body' tags, which caused the picker popup box to be mismanaged and invisible * The fix was to make the body selector more specific: 'body:first' did the job.
alandipert
added a commit
that referenced
this issue
Mar 21, 2019
* bootstrap-datepicker assumed the presence of only one 'body' tag on the page (document.body), and relied on the jQuery selector string 'body' to find it and use it as a container for the picker popup box * SVGs generated by networkD3 (and likely SVGs from elsewhere) break that assumption as they may contain multiple 'body' tags, which caused the picker popup box to be mismanaged and invisible * The fix was to make the body selector more specific: 'body:first' did the job.
alandipert
added a commit
that referenced
this issue
Mar 21, 2019
* bootstrap-datepicker assumed the presence of only one 'body' tag on the page (document.body), and relied on the jQuery selector string 'body' to find it and use it as a container for the picker popup box * SVGs generated by networkD3 (and likely SVGs from elsewhere) break that assumption as they may contain multiple 'body' tags, which caused the picker popup box to be mismanaged and invisible * The fix was to make the body selector more specific: 'body:first' did the job.
alandipert
added a commit
that referenced
this issue
Mar 22, 2019
* bootstrap-datepicker assumed the presence of only one 'body' tag on the page (document.body), and relied on the jQuery selector string 'body' to find it and use it as a container for the picker popup box * SVGs generated by networkD3 break that assumption as they may contain multiple 'body' tags, which caused the picker popup box to be mismanaged and invisible * The fix was to make the body selector more specific: 'body:first' did the job.
alandipert
added a commit
that referenced
this issue
Mar 22, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix in all cases was to make the body selector more specific: 'body:first' does the job.
alandipert
added a commit
that referenced
this issue
Mar 22, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
alandipert
added a commit
that referenced
this issue
Mar 27, 2019
* All of these were caused by the presence of multiple body tags on the page, which happened because networkD3's sankey plot generates SVGs containing body tags via SVG's foreignObject tag * In various places, the 'body' jQuery selector string is used under the assumption there is only one 'body' tag on the page. The presence of multiple 'body' tags breaks reliant code in strange ways. * The fix was to use document.body or 'body:first' instead of 'body'.
schloerke
added a commit
that referenced
this issue
Mar 27, 2019
* rc-v1.3.0: Remove reactlog from Remotes Fix #2349, #2329, #1817: bugs triggered by networkD3 sankey plot Improve bootstrap-datepicker update tools, add docs Add 'Fix datepicker DST bug' as patch Improve bootstrap-datepicker update script Re-import bootstrap-datepicker 1.6.4 Remove httpuv and reactlog from remotes Restore intuitive bookmarking behavior (#2360)
Thanks @alandipert and the Shiny team! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bringing up the issue by @nkk36 from #1959.
Issues:
date range input select box won't pop up; though manually typing values in min/max range does work (i.e., server reads it)
found a workaround from SO (https://stackoverflow.com/questions/44132864/part-of-daterangeinput-ui-gets-hidden-under-the-shiny-dashboard-header), but solution is unstable; work/fail at different sessions.
tags$div(tags$style(HTML(".dropdown-menu{z-index:20000 !important;}")))
as per @jcheng5 original request in Possible bug with dateRangeInput when plotting sankeyNetworks from networkD3 package #1959, JS console shows no error when this happen
reprex
from original post.The text was updated successfully, but these errors were encountered: