Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: make disabled months and years lighter gray #2690

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Datepicker: make disabled months and years lighter gray #2690

merged 3 commits into from
Oct 31, 2019

Conversation

wch
Copy link
Collaborator

@wch wch commented Oct 30, 2019 •
edited
Loading

Closes #2042, closes #2628.

This makes disabled months and years a lighter gray, which makes it more obvious that they're disabled.

When running shiny-examples/037-date-and-date-range/:

Before:

image

After:

image

Test notes:

Run shiny-examples/037-date-and-date-range/, and make sure that disabled years and months are light gray.

@wch wch requested a review from alandipert October 30, 2019 21:06
alandipert
alandipert approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@alandipert alandipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You may also consider addingcursor: not-allowed;, I think it could help with accessibility slightly.

@wch
Copy link
Collaborator Author

wch commented Oct 31, 2019

Good idea. I've made that change.

@wch wch merged commit ab79065 into master Oct 31, 2019
@wch wch deleted the wch-date-color branch October 31, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandipert alandipert alandipert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wch @alandipert