fix bookmarking bug #2297: don't break all bookmarking system if some URL params don't parse correctly #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… URL params don't parse correctly
|
Another attepmt to fix this issue, after #2770 was unsuccessful |
|
As a refresher: URL query params not parsing "correctly" can happen for a variety of reasons that don't mean something went wrong. For example, when sharing a link on facebook, facebook adds a query param that does not have quotes around it, so the json parser fails on it |
schloerke
approved these changes
Jun 9, 2022
wch
approved these changes
Jun 10, 2022
cpsievert
added a commit
that referenced
this pull request
Jun 14, 2022
…lect some parameters can now succeed when others fail
cpsievert
added a commit
that referenced
this pull request
Jun 14, 2022
…lect some parameters can now succeed when others fail (#3652)
schloerke
added a commit
that referenced
this pull request
Jun 26, 2022
* main: Update the `_inputs_` and `_values_` regular expr to support a trailing `=` (#3648) Enable `fileInput` to set the `capture` attribute (#3481) Update NEWS fix bookmarking bug #2297: don't break all bookmarking system if some URL params don't parse correctly (#3385) Update NEWS Corrected for stricter length checking in R 4.2.0 (#3625) Make mathjax configurable (#3650) Fixed automatic guessing of Content-Type in downloadHandler (#3393) Spelling `defintion` -> `definition` (#3649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.