Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test failures introduced by #3385 #3652

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix unit test failures introduced by #3385 #3652

merged 1 commit into from
Jun 14, 2022

Conversation

cpsievert
Copy link
Collaborator

A follow up to #3385 that fixes the unit test failures that it introduced

@cpsievert
Follow up to #3385: warn instead of message; update unit tests to ref…
a24cece 
…lect some parameters can now succeed when others fail
@cpsievert cpsievert requested a review from wch June 14, 2022 15:13
@cpsievert cpsievert mentioned this pull request Jun 14, 2022
Merged
2 tasks
@cpsievert cpsievert merged commit 474f140 into main Jun 14, 2022
@cpsievert cpsievert deleted the 3385-follow-up branch June 14, 2022 15:34
schloerke added a commit that referenced this pull request Jun 26, 2022
@schloerke
Merge branch 'main' into ts_strict_mode
f36c054 
* main:
  Follow up to #3385: warn instead of message; update unit tests to reflect some parameters can now succeed when others fail (#3652)
  Fix/update news (#3651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpsievert @wch