Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't import styler into NAMESPACE #119

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Don't import styler into NAMESPACE #119

merged 2 commits into from
Apr 24, 2024

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Apr 24, 2024

Fixes #117

@jcheng5 jcheng5 requested a review from cpsievert April 24, 2024 17:22
cpsievert
cpsievert approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcheng5
Copy link
Member Author

jcheng5 commented Apr 24, 2024

macOS CI failure seems unrelated

@jcheng5 jcheng5 merged commit 3b7f077 into main Apr 24, 2024
11 of 12 checks passed
@jcheng5 jcheng5 deleted the styler-import branch April 24, 2024 22:37
@lorenzwalthert
Copy link

Thanks @jcheng5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't formally import styler into NAMESPACE, but use ::
3 participants
@jcheng5 @lorenzwalthert @cpsievert