Add resolve arg to thematic_get_theme() and thematic_get_option() #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
requested changes
Jun 4, 2020
There was a problem hiding this comment.
My gut reaction is that resolve auto theme should be split into two functions. Resolve auto theme and resolve global auto theme.
Resolve auto theme should take a theme argument (which can default to global theme) and rerun the updated theme argument without setting the global value.
This would allow for users to call get theme with resolve true then resolve false and get two different answers.
The resolve global auto theme can be a wrapper around resolve auto theme that sets the global theme to the resolved global theme.
|
Good idea! That's connected to #25, so I'll close here and incorporate other there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22 and #27