Skip to content

Commit

Permalink
fix(pickers): fix the spacing of the searchbox is not uniform in all …
Browse files Browse the repository at this point in the history
…pickers (#3565)
  • Loading branch information
simonguo committed Jan 19, 2024
1 parent f2c53d0 commit 4c90a03
Show file tree
Hide file tree
Showing 191 changed files with 428 additions and 447 deletions.
1 change: 1 addition & 0 deletions docs/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ module.exports = {
// preventing "more than one copy of React" error
if (__USE_SRC__) {
Object.assign(config.resolve.alias, {
'@/internal': path.resolve(__dirname, '../src/internal'),
rsuite: path.resolve(__dirname, '../src'),
react: path.resolve(__dirname, './node_modules/react'),
'react-dom': path.resolve(__dirname, './node_modules/react-dom')
Expand Down
12 changes: 9 additions & 3 deletions docs/pages/components/cascader/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--start-code-->

```js
import { Cascader } from 'rsuite';
import { Cascader, Stack } from 'rsuite';
import { mockTreeData } from './mock';

const data = mockTreeData({
Expand All @@ -14,9 +14,15 @@ const data = mockTreeData({

const App = () => {
return (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<Cascader data={data} style={{ width: 224 }} />
</>
<Cascader
data={data}
searchable={false}
style={{ width: 224 }}
placeholder="Select without search"
/>
</Stack>
);
};

Expand Down
3 changes: 2 additions & 1 deletion docs/pages/components/cascader/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Cascader, Button, RadioGroup, Radio } from 'rsuite';
import { Cascader, Button, RadioGroup, Radio, Stack } from 'rsuite';
import DefaultPage from '@/components/Page';
import AdminIcon from '@rsuite/icons/Admin';
import FolderFillIcon from '@rsuite/icons/FolderFill';
Expand Down Expand Up @@ -34,6 +34,7 @@ export default function Page() {
AdminIcon,
FolderFillIcon,
PageIcon,
Stack,
mockAsyncData,
mockTreeData
}}
Expand Down
12 changes: 9 additions & 3 deletions docs/pages/components/check-picker/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--start-code-->

```js
import { CheckPicker } from 'rsuite';
import { CheckPicker, Stack } from 'rsuite';

const data = [
'Eugenia',
Expand All @@ -25,9 +25,15 @@ const data = [
].map(item => ({ label: item, value: item }));

const App = () => (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<CheckPicker data={data} style={{ width: 224 }} />
</>
<CheckPicker
data={data}
searchable={false}
style={{ width: 224 }}
placeholder="Select without search"
/>
</Stack>
);

ReactDOM.render(<App />, document.getElementById('root'));
Expand Down
3 changes: 2 additions & 1 deletion docs/pages/components/check-picker/index.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import React from 'react';
import { CheckPicker, Button, Checkbox, RadioGroup, Radio } from 'rsuite';
import { CheckPicker, Button, Checkbox, RadioGroup, Radio, Stack } from 'rsuite';
import DefaultPage from '@/components/Page';
import SpinnerIcon from '@rsuite/icons/legacy/Spinner';

export default function Page() {
return (
<DefaultPage
dependencies={{
Stack,
CheckPicker,
Button,
Checkbox,
Expand Down
13 changes: 10 additions & 3 deletions docs/pages/components/check-tree-picker/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--start-code-->

```js
import { CheckTreePicker } from 'rsuite';
import { CheckTreePicker, Stack } from 'rsuite';
import { mockTreeData } from './mock';

const data = mockTreeData({
Expand All @@ -13,9 +13,16 @@ const data = mockTreeData({
});

const App = () => (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<CheckTreePicker defaultExpandAll data={data} style={{ width: 280 }} />
</>
<CheckTreePicker
defaultExpandAll
data={data}
searchable={false}
style={{ width: 280 }}
placeholder="Select without search"
/>
</Stack>
);

ReactDOM.render(<App />, document.getElementById('root'));
Expand Down
3 changes: 2 additions & 1 deletion docs/pages/components/check-tree-picker/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { CheckTreePicker, Button, Toggle, Checkbox } from 'rsuite';
import { CheckTreePicker, Button, Toggle, Checkbox, Stack } from 'rsuite';
import SpinnerIcon from '@rsuite/icons/legacy/Spinner';
import PeoplesIcon from '@rsuite/icons/Peoples';
import AdminIcon from '@rsuite/icons/Admin';
Expand Down Expand Up @@ -33,6 +33,7 @@ export default function Page() {
SpinnerIcon,
PeoplesIcon,
AdminIcon,
Stack,
mockTreeData,
mockAsyncData
}}
Expand Down
12 changes: 9 additions & 3 deletions docs/pages/components/multi-cascader/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--start-code-->

```js
import { MultiCascader } from 'rsuite';
import { MultiCascader, Stack } from 'rsuite';
import { mockTreeData } from './mock';

const data = mockTreeData({
Expand All @@ -13,9 +13,15 @@ const data = mockTreeData({
});

const App = () => (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<MultiCascader data={data} style={{ width: 224 }} />
</>
<MultiCascader
data={data}
searchable={false}
style={{ width: 224 }}
placeholder="Select without search"
/>
</Stack>
);

ReactDOM.render(<App />, document.getElementById('root'));
Expand Down
3 changes: 2 additions & 1 deletion docs/pages/components/multi-cascader/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { MultiCascader, Button, Toggle, RadioGroup, Radio } from 'rsuite';
import { MultiCascader, Button, Toggle, RadioGroup, Radio, Stack } from 'rsuite';
import DefaultPage from '@/components/Page';
import PeoplesIcon from '@rsuite/icons/Peoples';
import AdminIcon from '@rsuite/icons/Admin';
Expand Down Expand Up @@ -32,6 +32,7 @@ export default function Page() {
Radio,
PeoplesIcon,
AdminIcon,
Stack,
mockAsyncData,
mockTreeData
}}
Expand Down
12 changes: 9 additions & 3 deletions docs/pages/components/select-picker/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
<!--start-code-->

```js
import { SelectPicker } from 'rsuite';
import { SelectPicker, Stack } from 'rsuite';

const data = ['Eugenia', 'Bryan', 'Linda', 'Nancy', 'Lloyd', 'Alice', 'Julia', 'Albert'].map(
item => ({ label: item, value: item })
);

const App = () => (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<SelectPicker data={data} style={{ width: 224 }} />
</>
<SelectPicker
data={data}
searchable={false}
style={{ width: 224 }}
placeholder="Select without search"
/>
</Stack>
);

ReactDOM.render(<App />, document.getElementById('root'));
Expand Down
5 changes: 3 additions & 2 deletions docs/pages/components/select-picker/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { SelectPicker, Button, RadioGroup, Radio, Loader } from 'rsuite';
import { SelectPicker, Button, RadioGroup, Radio, Loader, Stack } from 'rsuite';
import DefaultPage from '@/components/Page';
import SpinnerIcon from '@rsuite/icons/legacy/Spinner';

Expand All @@ -12,7 +12,8 @@ export default function Page() {
Button,
SpinnerIcon,
RadioGroup,
Radio
Radio,
Stack
}}
/>
);
Expand Down
13 changes: 10 additions & 3 deletions docs/pages/components/tree-picker/fragments/basic.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!--start-code-->

```js
import { TreePicker } from 'rsuite';
import { TreePicker, Stack } from 'rsuite';
import { mockTreeData } from './mock';

const data = mockTreeData({
Expand All @@ -13,9 +13,16 @@ const data = mockTreeData({
});

const App = () => (
<>
<Stack spacing={10} direction="column" alignItems="flex-start">
<TreePicker defaultExpandAll data={data} style={{ width: 246 }} />
</>
<TreePicker
defaultExpandAll
data={data}
searchable={false}
style={{ width: 246 }}
placeholder="Select without search"
/>
</Stack>
);

ReactDOM.render(<App />, document.getElementById('root'));
Expand Down
3 changes: 2 additions & 1 deletion docs/pages/components/tree-picker/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { TreePicker, Button } from 'rsuite';
import { TreePicker, Button, Stack } from 'rsuite';
import DefaultPage from '@/components/Page';
import SpinnerIcon from '@rsuite/icons/legacy/Spinner';
import PeoplesIcon from '@rsuite/icons/Peoples';
Expand Down Expand Up @@ -31,6 +31,7 @@ export default function Page() {
dependencies={{
TreePicker,
Button,
Stack,
SpinnerIcon,
PeoplesIcon,
AdminIcon,
Expand Down
1 change: 1 addition & 0 deletions docs/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"lib": ["dom", "dom.iterable", "esnext"],
"baseUrl": ".",
"paths": {
"@/internals/*": ["../src/internals/*"],
"@/*": ["./*"]
}
},
Expand Down
6 changes: 3 additions & 3 deletions src/AutoComplete/AutoComplete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import {
pickTriggerPropKeys,
PositionChildProps,
PickerComponent
} from '../Picker';

} from '../internals/Picker';
import Plaintext from '../internals/Plaintext';
import {
WithAsProps,
FormControlPickerProps,
Expand All @@ -33,7 +33,7 @@ import {
} from '../@types/common';

import { transformData, shouldDisplay } from './utils';
import Plaintext from '../Plaintext';

import Combobox from './Combobox';

export type ValueType = string;
Expand Down
2 changes: 1 addition & 1 deletion src/AutoComplete/Combobox.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { useCombobox } from '../Picker';
import { useCombobox } from '../internals/Picker';
import Input, { type InputProps } from '../Input';

interface ComboboxProps extends InputProps {
Expand Down
4 changes: 1 addition & 3 deletions src/AutoComplete/styles/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@
@import '../../styles/mixins/listbox';
@import '../../Input/styles/index';
@import '../../InputGroup/styles/index';
@import '../../Picker/styles/index';
@import '../../internals/Picker/styles/index';

.rs-auto-complete {
&-menu > {
// Auto complete items style the same to Picker menu items
.picker-menu-items-reset();

margin-top: @border-radius;
}

// The same to Picker select menu item
Expand Down
2 changes: 1 addition & 1 deletion src/AutoComplete/test/AutoCompleteStylesSpec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import AutoComplete from '../index';
import { getStyle, toRGB, inChrome } from '@test/utils';

import '../styles/index.less';
import { PickerHandle } from '../../Picker';
import { PickerHandle } from '../../internals/Picker';

describe('AutoComplete styles', () => {
it('Input should render the correct styles', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useCallback, useContext } from 'react';
import PropTypes from 'prop-types';
import { ButtonGroupContext } from '../ButtonGroup';
import SafeAnchor from '../SafeAnchor';
import Ripple from '../Ripple';
import Ripple from '../internals/Ripple';
import { isOneOf, useClassNames } from '../utils';
import { TypeAttributes, WithAsProps, RsRefForwardingComponent } from '../@types/common';

Expand Down
2 changes: 1 addition & 1 deletion src/Button/styles/index.less
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '../../styles/common';
@import '../../Ripple/styles/mixins';
@import '../../internals/Ripple/styles/mixins';
@import 'mixin.less';

//
Expand Down
2 changes: 1 addition & 1 deletion src/Calendar/MonthDropdown.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useCallback, useMemo } from 'react';
import PropTypes from 'prop-types';
import { AutoSizer, FixedSizeList, ListChildComponentProps } from '../Windowing';
import { AutoSizer, FixedSizeList, ListChildComponentProps } from '../internals/Windowing';
import { DateUtils, useClassNames } from '../utils';
import MonthDropdownItem from './MonthDropdownItem';
import { RsRefForwardingComponent, WithAsProps } from '../@types/common';
Expand Down
2 changes: 1 addition & 1 deletion src/Calendar/styles/index.less
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import '../../styles/common';
@import '../../styles/mixins/listbox';
@import '../../Button/styles/index';
@import '../../Picker/styles/mixin';
@import '../../internals/Picker/styles/mixin';

// Calendar panel
// ----------------------
Expand Down
7 changes: 3 additions & 4 deletions src/Cascader/Cascader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
import {
PickerToggle,
PickerPopup,
SearchBar,
PickerToggleTrigger,
usePickerClassName,
usePickerRef,
Expand All @@ -36,8 +35,8 @@ import {
listPickerPropTypes,
PickerHandle,
PickerToggleProps
} from '../Picker';

} from '../internals/Picker';
import SearchBox from '../internals/SearchBox';
import { ItemDataType, FormControlPickerProps } from '../@types/common';
import { useMap } from '../utils/useMap';

Expand Down Expand Up @@ -519,7 +518,7 @@ const Cascader = React.forwardRef(<T extends number | string>(props: CascaderPro
onKeyDown={onPickerKeyDown}
>
{searchable && (
<SearchBar
<SearchBox
placeholder={locale?.searchPlaceholder}
onChange={handleSearch}
value={searchKeyword}
Expand Down
2 changes: 1 addition & 1 deletion src/Cascader/DropdownMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import SpinnerIcon from '@rsuite/icons/legacy/Spinner';
import isUndefined from 'lodash/isUndefined';
import isNil from 'lodash/isNil';
import { shallowEqual, useClassNames, mergeRefs, useCustom, useEventCallback } from '../utils';
import { ListItem, useCombobox } from '../Picker';
import { ListItem, useCombobox } from '../internals/Picker';
import { ItemDataType, WithAsProps, RsRefForwardingComponent } from '../@types/common';
import { ValueType } from './Cascader';
import AngleLeftIcon from '@rsuite/icons/legacy/AngleLeft';
Expand Down

1 comment on commit 4c90a03

@vercel
Copy link

@vercel vercel bot commented on 4c90a03 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

rsuite-nextjs – ./docs

rsuite-nextjs-git-main-rsuite.vercel.app
rsuitejs.com
rsuite.vercel.app
rsuite-nextjs-rsuite.vercel.app

Please sign in to comment.