Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pickers): fix the spacing of the searchbox is not uniform in all pickers #3565

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

simonguo
Copy link
Member

  • fix(pickers): fix the spacing of the searchbox is not uniform in all pickers.
  • adjust the directory of all internal components.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 4:15am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 4:15am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 018d30a:

Sandbox Source
rsuite-tp-ci Configuration

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8ad3cfd) 93.44% compared to head (018d30a) 93.44%.

Files Patch % Lines
src/internals/Picker/Listbox.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3565      +/-   ##
==========================================
- Coverage   93.44%   93.44%   -0.01%     
==========================================
  Files         601      601              
  Lines       21303    21284      -19     
  Branches     2957     2956       -1     
==========================================
- Hits        19907    19888      -19     
  Misses        718      718              
  Partials      678      678              
Flag Coverage Δ
ChromeCi 93.39% <96.55%> (-0.01%) ⬇️
Firefox 92.83% <65.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 4c90a03 into main Jan 19, 2024
14 of 15 checks passed
@simonguo simonguo deleted the fix/picker-searchbox branch January 19, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant