Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Cascader): apply tree view pattern #2492

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

SevenOutman
Copy link
Member

Apply tree view pattern to Cascader's popup. For state as shown below

image

a11y before

image

a11y after

image

@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview May 19, 2022 at 8:25AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) May 19, 2022 at 8:25AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e411e6:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2492 (7e411e6) into main (69d2db2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2492   +/-   ##
=======================================
  Coverage   85.72%   85.73%           
=======================================
  Files         277      277           
  Lines        8695     8698    +3     
  Branches     2441     2444    +3     
=======================================
+ Hits         7454     7457    +3     
  Misses        653      653           
  Partials      588      588           
Flag Coverage Δ
ChromeCi 85.73% <100.00%> (+<0.01%) ⬆️
Firefox 85.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Cascader/DropdownMenu.tsx 89.55% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d2db2...7e411e6. Read the comment docs.

@SevenOutman SevenOutman merged commit f3a5808 into main May 19, 2022
@SevenOutman SevenOutman deleted the perf/Cascader-aria-tree branch May 19, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants