Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(next): fix vercel/next build failure #2776

Merged
merged 3 commits into from Sep 29, 2022
Merged

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Sep 29, 2022

  • build(deps): bump next from 12.1.0 to 12.1.6
  • docs: use react-select instead of react-text-mask

@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 8:13AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Sep 29, 2022 at 8:13AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3c7d24:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 85.35% // Head: 85.51% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (90cb40e) compared to base (c3648ac).
Patch has no changes to coverable lines.

❗ Current head 90cb40e differs from pull request most recent head c3c7d24. Consider uploading reports for the commit c3c7d24 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           feat/react-18    #2776      +/-   ##
=================================================
+ Coverage          85.35%   85.51%   +0.15%     
=================================================
  Files                299      297       -2     
  Lines               9200     9120      -80     
  Branches            2604     2580      -24     
=================================================
- Hits                7853     7799      -54     
+ Misses               706      692      -14     
+ Partials             641      629      -12     
Flag Coverage Δ
ChromeCi 85.48% <ø> (+0.18%) ⬆️
Firefox 85.46% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/toaster/ToastContainer.tsx 86.53% <0.00%> (-5.62%) ⬇️
src/Modal/utils.ts 84.61% <0.00%> (-5.13%) ⬇️
src/Modal/Modal.tsx 91.93% <0.00%> (-3.23%) ⬇️
src/Picker/DropdownMenu.tsx 78.20% <0.00%> (-1.55%) ⬇️
src/Menu/Menu.tsx 91.33% <0.00%> (-0.67%) ⬇️
src/CheckPicker/CheckPicker.tsx 85.21% <0.00%> (-0.13%) ⬇️
src/SelectPicker/SelectPicker.tsx 90.09% <0.00%> (-0.10%) ⬇️
src/Tree/Tree.tsx 100.00% <0.00%> (ø)
src/toaster/toaster.tsx 100.00% <0.00%> (ø)
src/utils/useUniqueId.ts 100.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonguo simonguo changed the title build(deps): bump next from 12.1.0 to 12.1.6 doc: fix vercel/next build failure Sep 29, 2022
@simonguo simonguo changed the title doc: fix vercel/next build failure docs(next): fix vercel/next build failure Sep 29, 2022
@simonguo simonguo changed the base branch from main to feat/react-18 September 29, 2022 07:59
@superman66
Copy link
Member

superman66 commented Sep 30, 2022

The main branch has the same problem when building on vercel.
https://vercel.com/rsuite/rsuite-nextjs/8XgPqiXRwG9WAKGXEx6ghTYFPGsz

@simonguo
Copy link
Member Author

simonguo commented Oct 8, 2022

@superman66
The reason for the build failure is that there are version conflicts or out-of-date versions of multiple libraries.
react-virtualized is still used under the main branch, so this fix does not completely solve the problem under the main branch. Either find a way to ignore the problem in vercel, or wait for the feat/react-18 branch to be merged into the main branch.

SevenOutman pushed a commit that referenced this pull request Oct 27, 2022
* feat: support react 18 for toaster

* refactor(toaster): use createRoot().render instead of render

* test: fix wrong test scripts

* build: bump eslint-plugin-react 7.30 for react 18

* ci: update nodejs-ci.yml

* build: bump prop-types 15.8.1

* test(Calendar): fix test error

* build(deps): bump @types/react 17.0.47

* refactor(useUniqueId): use React 18 new API useId in useUniqueId

* test(Nav): fix failed test cases

* test(Collapse): fix failed test cases

* test: fix merged errors

* test: fix test failure caused by userEvent upgrade

* build(deps): bump @testing-library/user-event@14.3.0

* fix: merge branch `main` into feat/react-18

* fix(Disclosure): prevent onmouseout from firing on child elements (#2646)

* test(useCalendar): missing act on event action

* refactor(virtualized): use react-window instead of react-virtualized (#2661)

* refactor(virtualized): use react-window instead of react-virtualized

* fix(AutoSizer): failed to compile

* test: ignore style checking for Windowing

* docs: update example for virtualized

* docs: add guidance for Optimizing Performance (#2681)

* docs: add guidance for Optimizing Performance

* docs: fix static export failure

* test: fix unrecognized label for react 18

* test(Sidenav): fix tests for react 18

* build(deps): bump @docsearch/react 3.2.1 in docs

* build(deps): bump react to 17.0.2 from 17.0.1

* docs(next): fix vercel/next build failure (#2776)

* build(deps): bump next to 12.1.6 from 12.1.0

* docs: use react-select instead of react-text-mask

* fix(AutoSizer): fix virtualized list width not being updated (#2806)

* test: fix test errors caused by code branch merge

* fix(pickers): fix text overflow issue on option values (#2826)

* docs(CheckPicker): fix full data for example

* test(CheckPicker): fix test virtualized list width issue

* fix(pickers): fix styling issues with virtualized lists (#2825)

* fix(pickers): fix styling issues with virtualized lists

* style: code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants