Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pickers): fix styling issues with virtualized lists #2825

Merged
merged 3 commits into from Oct 25, 2022

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Oct 19, 2022

  • Clean up style patches for ReactVirtualized.
  • Make the width of the virtualized list fill the container.

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Oct 22, 2022 at 2:12AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
rsuite-v4 ⬜️ Ignored (Inspect) Oct 22, 2022 at 2:12AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d684398:

Sandbox Source
rsuite-tp-ci Configuration

@SevenOutman SevenOutman merged commit 680f448 into feat/react-18 Oct 25, 2022
@SevenOutman SevenOutman deleted the fix/picker-virtualized branch October 25, 2022 07:14
SevenOutman pushed a commit that referenced this pull request Oct 27, 2022
* feat: support react 18 for toaster

* refactor(toaster): use createRoot().render instead of render

* test: fix wrong test scripts

* build: bump eslint-plugin-react 7.30 for react 18

* ci: update nodejs-ci.yml

* build: bump prop-types 15.8.1

* test(Calendar): fix test error

* build(deps): bump @types/react 17.0.47

* refactor(useUniqueId): use React 18 new API useId in useUniqueId

* test(Nav): fix failed test cases

* test(Collapse): fix failed test cases

* test: fix merged errors

* test: fix test failure caused by userEvent upgrade

* build(deps): bump @testing-library/user-event@14.3.0

* fix: merge branch `main` into feat/react-18

* fix(Disclosure): prevent onmouseout from firing on child elements (#2646)

* test(useCalendar): missing act on event action

* refactor(virtualized): use react-window instead of react-virtualized (#2661)

* refactor(virtualized): use react-window instead of react-virtualized

* fix(AutoSizer): failed to compile

* test: ignore style checking for Windowing

* docs: update example for virtualized

* docs: add guidance for Optimizing Performance (#2681)

* docs: add guidance for Optimizing Performance

* docs: fix static export failure

* test: fix unrecognized label for react 18

* test(Sidenav): fix tests for react 18

* build(deps): bump @docsearch/react 3.2.1 in docs

* build(deps): bump react to 17.0.2 from 17.0.1

* docs(next): fix vercel/next build failure (#2776)

* build(deps): bump next to 12.1.6 from 12.1.0

* docs: use react-select instead of react-text-mask

* fix(AutoSizer): fix virtualized list width not being updated (#2806)

* test: fix test errors caused by code branch merge

* fix(pickers): fix text overflow issue on option values (#2826)

* docs(CheckPicker): fix full data for example

* test(CheckPicker): fix test virtualized list width issue

* fix(pickers): fix styling issues with virtualized lists (#2825)

* fix(pickers): fix styling issues with virtualized lists

* style: code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants