Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioGroup): fix style in picker appearance #3274

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

SevenOutman
Copy link
Member

@SevenOutman SevenOutman commented Jul 4, 2023

Fix 3 styling issues

  • Horizontal spacing between radios was 30px, which should have been 20px - this issue was introduced in v5.34.1 by #3215
  • Total height of the RadioGroup was 38px, which should have been 36px - this also led to vertical mis-alignment of the radio text
  • Leading/trailing padding of the RadioGroup was 10px, which should have been 12px

Preview

https://rsuite-nextjs-git-fix-radiogroup-picker-style-rsuite.vercel.app/components/radio/#radio-group-picker

Screenshots

Before

image

After

image

Design

image

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview Jul 4, 2023 6:28am
1 Ignored Deployment
Name Status Preview Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Jul 4, 2023 6:28am

@SevenOutman SevenOutman requested a review from simonguo July 4, 2023 06:29
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f280479:

Sandbox Source
rsuite-tp-ci Configuration

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (623ecde) 93.36% compared to head (f280479) 93.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3274   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files         568      568           
  Lines       20204    20204           
  Branches     2767     2767           
=======================================
  Hits        18864    18864           
  Misses        688      688           
  Partials      652      652           
Flag Coverage Δ
ChromeCi 93.32% <ø> (ø)
Firefox 92.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeightonYao
Copy link

Nice~!(^-^)V

@SevenOutman SevenOutman merged commit f673c85 into main Jul 5, 2023
7 checks passed
@SevenOutman SevenOutman deleted the fix/RadioGroup-picker-style branch July 5, 2023 03:50
@LeightonYao
Copy link

yeah, great😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants